Remove job from pause/unpause #12249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Murdaca <me@runcom.ninja>
Member
Author
There was a problem hiding this comment.
no need to be checked...handler for this route is only run if name is not empty...same below for unpause...
Member
Author
There was a problem hiding this comment.
because I've added it in other server functions last time after the review.. I'm gonna create an issue to remove the check
Contributor
There was a problem hiding this comment.
feel free to add a comment on top of this line :)
Member
Author
There was a problem hiding this comment.
@crosbymichael I've created an issue #12251 but I can't label it beginner or something
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Apr 9, 2015
Remove job from pause/unpause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonio Murdaca me@runcom.ninja