Remove engine.Job from diff #12183
Merged
Remove engine.Job from diff #12183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api/server/server.go
Outdated
Contributor
There was a problem hiding this comment.
I think we may want to check to see if "name" is empty to return a nicer error message.
Member
Author
There was a problem hiding this comment.
👍 thanks there wasn't any check I'll add one now!
Signed-off-by: Antonio Murdaca <me@runcom.ninja>
Member
Author
|
@duglin made your proposed changes |
Contributor
|
thanks LGTM |
Contributor
|
Thanks! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #12151
I'll happly work on another of this if there's need and this is ok ^.^
Signed-off-by: Antonio Murdaca me@runcom.ninja