Skip to content

Conversation

@hqhq
Copy link
Contributor

@hqhq hqhq commented Apr 7, 2015

Signed-off-by: Qiang Huang h.huangqiang@huawei.com

@hqhq
Copy link
Contributor Author

hqhq commented Apr 7, 2015

It's a new version of an early one #9536

@crosbymichael
Copy link
Contributor

LGTM

@hqhq can you please base this then it's good to merge

@ehazlett
Copy link
Contributor

LGTM

@icecrime
Copy link
Contributor

Pushing to 3-needs-doc-review so we can continue progressing on this while you rebase!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add only for NUMA systems here - and then the man page and cli docs would say that in the cmdline flag summary too.

@hqhq hqhq force-pushed the hq_add_cpusest_mems2 branch from 1c61ccb to 96ece7a Compare April 14, 2015 02:52
@hqhq
Copy link
Contributor Author

hqhq commented Apr 14, 2015

Rebased.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a space after "system"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take it, thanks.

hqhq added 2 commits April 15, 2015 09:33
Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
@hqhq
Copy link
Contributor Author

hqhq commented Apr 15, 2015

@thaJeztah Thanks for your review, since docs in this PR are almost the same as it in #9536, which are already been fully discussed, and got two docs LGTM from @SvenDowideit and @fredlf .
So for some A or B choice and sentence change I just leave it as it was. Hope you are OK with that :)

@hqhq hqhq force-pushed the hq_add_cpusest_mems2 branch from 96ece7a to f8dc7e8 Compare April 15, 2015 02:25
@hqhq
Copy link
Contributor Author

hqhq commented Apr 15, 2015

Updated, thanks @thaJeztah

@thaJeztah
Copy link
Member

Thanks!

@moxiegirl
Copy link
Contributor

LGTM

@moxiegirl
Copy link
Contributor

ping @jamtur01 @fredlf @SvenDowideit

@jamtur01
Copy link
Contributor

LGTM

@cpuguy83
Copy link
Member

LGTM

cpuguy83 added a commit that referenced this pull request Apr 15, 2015
@cpuguy83 cpuguy83 merged commit 2ecccda into moby:master Apr 15, 2015
@hqhq hqhq deleted the hq_add_cpusest_mems2 branch April 16, 2015 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants