Remove jobs from registry.Service #11974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `registry.Service` a first class type and does not use jobs to interact with this type. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Contributor
|
💃 |
Contributor
|
omg its so pretty LGTM |
Contributor
|
LGTM! |
Contributor
|
That's so much simpler <3 One nit, otherwise LGTM. |
Contributor
There was a problem hiding this comment.
@crosbymichael Also NewDaemonFromDirectory is not used, you can rename it to NewDaemon.
Contributor
Author
There was a problem hiding this comment.
is it worth the CI time?
Contributor
|
@crosbymichael thanks, much simpler with registry.Service in Daemon. I'll do that for the other things! |
Contributor
|
LGTM |
tiborvass
added a commit
that referenced
this pull request
Apr 1, 2015
Remove jobs from registry.Service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
registry.Servicea first class type and does not use jobsto interact with this type.
Signed-off-by: Michael Crosby crosbymichael@gmail.com