Add test for net=container and links#11686
Conversation
Signed-off-by: willhf <willhf@gmail.com>
|
LGTM |
|
Do we need to modify the code at: |
|
@willhf Can you please update your PR addressing @duglin's comment? Thanks! |
Signed-off-by: willhf <willhf@gmail.com>
|
@icecrime done! |
|
@estesp True, but until we figure this out, don't you think this is a valid patch? I'm thinking LGTM for now. |
|
@icecrime yes, actually, let's merge this as the other work isn't really complete, and it is correct that even with #11369, it is still correct that both flags together do not work (see the @cpuguy83 comment here: #9340 (comment)) Given that, I'm good with merging this now and then understanding how we appropriately finish out the updated capability that you can link to another container started with LGTM |
|
No docs needs as far as I can tell. |
Add test for net=container and links
closes #9340
In writing a test for this we discovered that the check was wrong, hence the prefix change.