Move daemon-only flags into the daemon config struct#10453
Move daemon-only flags into the daemon config struct#10453jessfraz merged 1 commit intomoby:masterfrom
Conversation
|
Can you please sign your commits following these rules: https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
|
99ee814 to
73a0adc
Compare
|
Done and also fixed some gofmt issues. The flag ordering seems to be completely arbitrary so I've just inserted them in a random place. |
docker/flags.go
Outdated
There was a problem hiding this comment.
No, these can be used elsewhere.
There was a problem hiding this comment.
Where? The daemon is responsible for creating the socket and serving the API. These arguments don't apply to any other docker subcommands...
There was a problem hiding this comment.
I know "docker info" at least has different behavior with "-D" passed to
either the client or the daemon.
There was a problem hiding this comment.
Which is exactly why I left "-D" alone.
There was a problem hiding this comment.
(the only things changed are -G and --api-enable-cors)
There was a problem hiding this comment.
Oh wow read this diff wrong
There was a problem hiding this comment.
The tradeoff of enforced gofmt :)
|
@aidanhs Following your last comments on #10535 (comment) Docker maintainers (> Docker Inc), are currently overwhelmed by the 1.5 release hence our slow down in PR review. We read all comments, and we will review all PRs in due time, so please bear with us :) Btw, your PR here seems very reasonable and we should be able to merge it reasonably quickly, so if you could rebase that'd be fantastic! Thanks for your patience! |
|
needs a rebase, so sorry, if you ping me after I will review immediately |
Signed-off-by: Aidan Hobson Sayers <aidanhs@cantab.net>
73a0adc to
06ea5fe
Compare
|
@tiborvass that's fine, Docker is hardly a low activity project, I can imagine there are busy periods which is why I made my comment - no point spending time if maintainers are busy with other things :) @jfrazelle ping |
|
LGTM |
1 similar comment
|
LGTM |
Move daemon-only flags into the daemon config struct
No description provided.