Extract hostname from (hostname.domainname)#950
Merged
aboch merged 1 commit intomoby:masterfrom Mar 1, 2016
thockin:hostname_domainname
Merged
Extract hostname from (hostname.domainname)#950aboch merged 1 commit intomoby:masterfrom thockin:hostname_domainname
aboch merged 1 commit intomoby:masterfrom
thockin:hostname_domainname
Conversation
This approach allows the user to provide a FQDN as hostname if that is what they want in their container, or to provide distinct host and domain parts. In both cases we will correctly extract the first token for /etc/hosts. Signed-off-by: Tim Hockin <thockin@google.com>
Contributor
Author
|
Rebased, awaiting review. |
Contributor
Author
|
What more is needed to merge? Just curious on workflow |
Contributor
|
LGTM |
aboch
added a commit
that referenced
this pull request
Mar 1, 2016
Extract hostname from (hostname.domainname)
|
@thockin We usually try to get two LGTMs to merge a change. After the next vendor in of libnetwork we can merge docker/docker #20200 |
tonistiigi
pushed a commit
to tonistiigi/docker
that referenced
this pull request
Mar 18, 2016
This allows users to provide a FQDN as hostname or to use distinct hostname and domainname parts. Depends on moby/libnetwork#950 Signed-off-by: Tim Hockin <thockin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach allows the user to provide a FQDN as hostname if that is what
they want in their container, or to provide distinct host and domain parts. In
both cases we will correctly extract the first token for /etc/hosts.
xref: moby/moby#20200 and moby/moby#14282