Merged
Conversation
Contributor
mavenugo
commented
Sep 10, 2015
- godep updates on the updated dependancies
166186f to
31449dd
Compare
Contributor
Author
Contributor
Author
|
@mrjana updated the changes with your suggestion. CI still passes, which is good :). PTAL |
Contributor
|
@mavenugo Can we not change all godeps to just introduce runc in godeps? github bails out from showing diffs in the This should work and I have done it many times |
Signed-off-by: Madhu Venugopal <madhu@docker.com>
Contributor
Author
Contributor
|
LGTM |
Contributor
Author
|
@mrjana thanks for all the good comments. Its a shame that they are not showing up in github :( |
Signed-off-by: Madhu Venugopal <madhu@docker.com>
Contributor
|
@mavenugo Thanks for taking care of the comments. LGTM |
mrjana
added a commit
that referenced
this pull request
Sep 11, 2015
External key handling via reexec
mavenugo
added a commit
to mavenugo/docker
that referenced
this pull request
Sep 11, 2015
libnetwork waiting on : moby/libnetwork#515 libcontainer waiting on : opencontainers/runc#261 Due to libseccomp challenges, I cherry-picked opencontainers/runc#261 on top of runc v0.0.3 which is seen in my private fork that is vendored-in here Signed-off-by: Madhu Venugopal <madhu@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.