Skip to content

External key handling via reexec#515

Merged
mrjana merged 2 commits intomoby:masterfrom
mavenugo:uds_uns
Sep 11, 2015
Merged

External key handling via reexec#515
mrjana merged 2 commits intomoby:masterfrom
mavenugo:uds_uns

Conversation

@mavenugo
Copy link
Contributor

  • godep updates on the updated dependancies

@mavenugo mavenugo force-pushed the uds_uns branch 2 times, most recently from 166186f to 31449dd Compare September 11, 2015 03:44
@mavenugo
Copy link
Contributor Author

@mrjana @aboch fixed the CI issue. PTAL.

@mavenugo
Copy link
Contributor Author

@mrjana updated the changes with your suggestion. CI still passes, which is good :). PTAL

@mrjana
Copy link
Contributor

mrjana commented Sep 11, 2015

@mavenugo Can we not change all godeps to just introduce runc in godeps? github bails out from showing diffs in the Files Chaged tab because of too many changes and that prevents me from providing my comments in that tab (only when I provide my comments there it stays there with the PR). Why don't we just update godeps for runc alone by doing the following:

godep save github.com/opencontainers/runc

This should work and I have done it many times

Signed-off-by: Madhu Venugopal <madhu@docker.com>
@mavenugo
Copy link
Contributor Author

@mrjana as discussed, we have some challenges with the godep save & we can handle with that cleanly at a later point.
@aboch thanks for the comments. fixed them. Though i dont have to change the buf len to 1024 in return, I still made the changes to be consistent.

@aboch
Copy link
Contributor

aboch commented Sep 11, 2015

LGTM

@mavenugo
Copy link
Contributor Author

@mrjana thanks for all the good comments. Its a shame that they are not showing up in github :(
took care of them all. PTAL.

Signed-off-by: Madhu Venugopal <madhu@docker.com>
@mrjana
Copy link
Contributor

mrjana commented Sep 11, 2015

@mavenugo Thanks for taking care of the comments. LGTM

mrjana added a commit that referenced this pull request Sep 11, 2015
External key handling via reexec
@mrjana mrjana merged commit 1853ae0 into moby:master Sep 11, 2015
mavenugo added a commit to mavenugo/docker that referenced this pull request Sep 11, 2015
libnetwork waiting on : moby/libnetwork#515
libcontainer waiting on : opencontainers/runc#261

Due to libseccomp challenges, I cherry-picked opencontainers/runc#261
on top of runc v0.0.3 which is seen in my private fork that is
vendored-in here

Signed-off-by: Madhu Venugopal <madhu@docker.com>
@mavenugo mavenugo deleted the uds_uns branch July 5, 2016 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants