Add static routes to the remote driver.#240
Merged
aboch merged 1 commit intomoby:masterfrom Jun 3, 2015
Metaswitch:remote-driver-static-routes
Merged
Add static routes to the remote driver.#240aboch merged 1 commit intomoby:masterfrom Metaswitch:remote-driver-static-routes
aboch merged 1 commit intomoby:masterfrom
Metaswitch:remote-driver-static-routes
Conversation
Contributor
Author
drivers/remote/messages.go
Outdated
Contributor
There was a problem hiding this comment.
Please make this to fit in a single line since there is only one var declared
Signed-off-by: Tom Denham <tom.denham@metaswitch.com>
Contributor
Author
|
@mrjana I've pushed changes for two of your comments. I don't think I can implement the other - see #240 (comment) |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
aboch
added a commit
that referenced
this pull request
Jun 3, 2015
Add static routes to the remote driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Denham tom.denham@metaswitch.com