Adding synchronization around peerAdd and peerDelete to prevent network connectivity issue#2356
Merged
mavenugo merged 1 commit intomoby:masterfrom Apr 6, 2019
Merged
Conversation
|
Please sign your commits following these rules: $ git clone -b "RS1-Synch" git@github.com:pradipd/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
pradipd
commented
Apr 5, 2019
Contributor
Author
|
FYI to docker team: @mavenugo @danil @selansen |
dani-docker
suggested changes
Apr 5, 2019
dani-docker
suggested changes
Apr 5, 2019
dani-docker
suggested changes
Apr 5, 2019
…rk connectivity issue Signed-off-by: Pradip Dhara <pradipd@microsoft.com>
mavenugo
reviewed
Apr 5, 2019
| } | ||
|
|
||
| func endpointRequest(method, path, request string) (*hcsshim.HNSEndpoint, error) { | ||
| if windowsBuild == 14393 { |
Contributor
There was a problem hiding this comment.
@pradipd is this a fixed version for WS 2016 server or will this change for every patch ?
Contributor
Author
There was a problem hiding this comment.
fixed version. We (windows) should really have a constant for this.
Contributor
There was a problem hiding this comment.
Thanks. We see it as a hcsshim constant osversion.RS5. Thanks.
Merged
This was referenced Apr 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple networks are present in a Swarm Cluster, multiple peerAdd or peerDelete calls are an issue for different remote endpoints. These threads are updating the remote endpoint to HNS parallelly. In 2016 HNS code base, we don't have synchronization around remoteEndpoint addition and deletion. So serializing the peerAdd and peerDelete calls from docker network driver.