Modify driver Join api to only allow dst prefix#193
Merged
mavenugo merged 1 commit intomoby:masterfrom May 21, 2015
Merged
Conversation
sandbox/namespace_linux.go
Outdated
Contributor
There was a problem hiding this comment.
Since you are not using suffix anywhere else, have you considered:
i.DstName = fmt.Sprintf("%s%d", i.DstName, n.nextIfIndex)
If you think it is cleaner as it is now, it's fine too.
Contributor
Author
There was a problem hiding this comment.
No, what you suggested is better. I will push new diffs with the changes.
Contributor
Author
|
@aboch updated with new diffs and rebase |
Contributor
|
LGTM |
Currently the driver api allows the driver to specify the full interface name for the interface inside the container. This is not appropriate since the driver does not have the full view of the sandbox to correcly allocate an unambiguous interface name. Instead with this PR the driver will be allowed to specify a prefix for the name and libnetwork and sandbox layers will disambiguate it with an appropriate suffix. Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
Contributor
|
LGTM |
mavenugo
added a commit
that referenced
this pull request
May 21, 2015
Modify driver Join api to only allow dst prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the driver api allows the driver to specify the
full interface name for the interface inside the container.
This is not appropriate since the driver does not have the full
view of the sandbox to correcly allocate an unambiguous interface
name. Instead with this PR the driver will be allowed to specify
a prefix for the name and libnetwork and sandbox layers will
disambiguate it with an appropriate suffix.
Signed-off-by: Jana Radhakrishnan mrjana@docker.com