Cleaning up windows overlay network driver code and making it rely on HNS network information#1636
Merged
mavenugo merged 1 commit intomoby:masterfrom Feb 14, 2017
msabansal:overlayfix
Merged
Cleaning up windows overlay network driver code and making it rely on HNS network information#1636mavenugo merged 1 commit intomoby:masterfrom msabansal:overlayfix
mavenugo merged 1 commit intomoby:masterfrom
msabansal:overlayfix
Conversation
Signed-off-by: msabansal <sabansal@microsoft.com>
Contributor
|
@msabansal the bulk of the changes are removing the existing serf control-plane code which is obviously not used in swarm-mode. Since, Windows Overlay supports only the swarm-mode and is not supported for the external KV-Store mechanism, am fine with this change. LGTM |
Closed
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Mar 6, 2023
The overlay driver was creating a global store whenever netlabel.GlobalKVClient was specified in its config argument. This specific label is not used anymore since 142b522 (moby#44875). The local datastore is unused since 66895df (moby/libnetwork#1636). Finally, the sync.Once properties are never used. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Mar 31, 2023
The overlay driver was creating a global store whenever netlabel.GlobalKVClient was specified in its config argument. This specific label is not used anymore since 142b522 (moby#44875). The local datastore is unused since 66895df (moby/libnetwork#1636). Finally, the sync.Once properties are never used. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Mar 31, 2023
The overlay driver was creating a global store whenever netlabel.GlobalKVClient was specified in its config argument. This specific label is unused anymore since 142b522 (moby#44875). It was also creating a local store whenever netlabel.LocalKVClient was specificed in its config argument. This store is unused since moby/libnetwork@9e72136 (moby/libnetwork#1636). Finally, the sync.Once properties are never used and thus can be deleted. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Apr 6, 2023
The overlay driver was creating a global store whenever netlabel.GlobalKVClient was specified in its config argument. This specific label is unused anymore since 142b522 (moby#44875). It was also creating a local store whenever netlabel.LocalKVClient was specificed in its config argument. This store is unused since moby/libnetwork@9e72136 (moby/libnetwork#1636). Finally, the sync.Once properties are never used and thus can be deleted. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issues when docker daemon goes out of sync and the network is not cleaned up either in the libnetwork overlay plugin's store or HNS store. We clean up the network in both the stores and then add them again.
Signed-off-by: msabansal sabansal@microsoft.com