Skip to content

Include _caml_mirage_iopage_{alloc_pages,get_addr}#319

Merged
rn merged 1 commit intomoby:masterfrom
djs55:fix-ci
Sep 14, 2021
Merged

Include _caml_mirage_iopage_{alloc_pages,get_addr}#319
rn merged 1 commit intomoby:masterfrom
djs55:fix-ci

Conversation

@djs55
Copy link
Copy Markdown
Collaborator

@djs55 djs55 commented Sep 14, 2021

Fixes the recent CI error. Caused by stubs moving from one .a to another in an upstream dependency.

I think the combination of #304 and this should fix #301.

Fixes CI failure seen in #318

It would be nice to have a better set of Makefile rules for finding these C stubs.

Signed-off-by: David Scott dave.scott@docker.com

Fixes the recent CI error. Caused by stubs moving from one .a to
another in an upstream dependency.

Signed-off-by: David Scott <dave@recoil.org>
Copy link
Copy Markdown
Contributor

@fredericdalleau fredericdalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rn rn merged commit 10d79f4 into moby:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails to link with latest OCaml dependencies

3 participants