Skip to content

Fix assertion turned into assignment#318

Merged
rn merged 2 commits intomoby:masterfrom
fredericdalleau:various-fixes
Sep 14, 2021
Merged

Fix assertion turned into assignment#318
rn merged 2 commits intomoby:masterfrom
fredericdalleau:various-fixes

Conversation

@fredericdalleau
Copy link
Copy Markdown
Contributor

The assertion is supposed to check the value, but the typo makes it
an assignment. Hence it is always true.

Fixes GHSL-2021-058

Copy link
Copy Markdown
Collaborator

@djs55 djs55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (oops!)

djs55 and others added 2 commits September 14, 2021 17:12
Fixes the recent CI error. Caused by stubs moving from one .a to
another in an upstream dependency.

Signed-off-by: David Scott <dave@recoil.org>
The qassertion is supposed to check the value but the typo makes it
an assignment. Hence it is always true,

Signed-off-by: Frederic Dalleau <frederic.dalleau@docker.com>
@rn rn merged commit adc4ea8 into moby:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants