This repository was archived by the owner on Apr 29, 2025. It is now read-only.
refer to mirage module types modules by new name#433
Closed
yomimono wants to merge 1 commit intomoby:masterfrom
Closed
refer to mirage module types modules by new name#433yomimono wants to merge 1 commit intomoby:masterfrom
yomimono wants to merge 1 commit intomoby:masterfrom
Conversation
Contributor
|
CI failed with: moby/datakit.logs@46c2ea4#diff-dc1d71bbb5c4d2a5e936db79ef10c19fR121 |
Contributor
|
FWIW I think I saw the same error earlier today when building an ocaml package locally in an |
Signed-off-by: Mindy Preston <mindy.preston@docker.com>
Contributor
|
I guess this needs to wait for Mirage 3 to be released. |
Contributor
|
CentOS and Fedora are the only containers that use the Docker Cloud-hosted solver.ocaml.io, so you will see that error if the infra is down. The builds can be restarted. |
Contributor
Author
|
@talex5 if it bugs you to leave this PR open, I'm happy to resubmit it later or point it at a mirage-dev branch. |
Contributor
|
I think it's fine to keep it open. I've tagged it as tracking. |
avsm
added a commit
to avsm/mirage-dev
that referenced
this pull request
Jan 18, 2017
see moby/datakit#433 for upstream PR
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V1 is now Mirage_types, and V1_LWT is now Mirage_types_lwt, as of MirageOS version 3.0.0.