Merged
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
AkihiroSuda
reviewed
Jul 24, 2017
| } | ||
|
|
||
| func Local(name string, opts ...LocalOption) State { | ||
| gi := &LocalInfo{} |
AkihiroSuda
approved these changes
Jul 24, 2017
Member
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM, the nit is not worth fixing
smira
added a commit
to smira/buildkit
that referenced
this pull request
Jul 17, 2019
Example:
RUN --security=insecure cat /proc/self/status | grep CapEff
moby#84 0.093 CapEff: 0000003fffffffff
Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
smira
added a commit
to smira/buildkit
that referenced
this pull request
Jul 17, 2019
Example:
RUN --security=insecure cat /proc/self/status | grep CapEff
moby#84 0.093 CapEff: 0000003fffffffff
Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
smira
added a commit
to smira/buildkit
that referenced
this pull request
Jul 18, 2019
Example:
RUN --security=insecure cat /proc/self/status | grep CapEff
moby#84 0.093 CapEff: 0000003fffffffff
Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
smira
added a commit
to smira/buildkit
that referenced
this pull request
Jul 18, 2019
Example:
RUN --security=insecure cat /proc/self/status | grep CapEff
moby#84 0.093 CapEff: 0000003fffffffff
Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
alexcb
pushed a commit
to alexcb/buildkit
that referenced
this pull request
Jul 20, 2022
wait for lazycachemanager in parallel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
client/llbpackage so that it can be extended with steps with custom proto marshalers. As an example see nested builds implementation outside of llb package in https://github.com/moby/buildkit/pull/83/files#diff-7c4a9f9ba5cb496f10617ea08ad80f37Only change to the syntax is that
llb.Stateis not a pointer anymore.@AkihiroSuda