hack: use tools build constraint for generated-files deps#3236
Merged
crazy-max merged 2 commits intomoby:masterfrom Nov 25, 2022
Merged
hack: use tools build constraint for generated-files deps#3236crazy-max merged 2 commits intomoby:masterfrom
crazy-max merged 2 commits intomoby:masterfrom
Conversation
f2c9958 to
47bd4b3
Compare
jedevc
reviewed
Oct 31, 2022
Member
jedevc
left a comment
There was a problem hiding this comment.
Looks mostly good to me - I have some confusion around pb_tools.go, but otherwise looks good to me.
Nice to see the collection of shell scripts shrinking and moving into Dockerfiles.
47bd4b3 to
956bfce
Compare
956bfce to
27c2d39
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
27c2d39 to
abe457d
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
abe457d to
e1b3b6c
Compare
jedevc
approved these changes
Nov 25, 2022
Member
jedevc
left a comment
There was a problem hiding this comment.
The need for tools.go is still kind of frustrating, but it feels a bit like a necessary evil - it's still an improvement on what we have today, so seems fine to me 🤷
PTAL @tonistiigi
Member
Author
|
As discussed with tonis, I have updated the comment in the package to warn users if they want to add other tools. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3187
follow-up docker/buildx#1296 (comment)
Inferred
go installfromgo.modusing tools build constraint so proto generation is aligned.github.com/golang/protobuf/protoc-gen-goswitches from1.3.5to1.5.2.Looking at the release notes and since 1.4.0:
The API of this new module is not drop-in compatible with the earlier
github.com/golang/protobufmodule. See https://github.com/protocolbuffers/protobuf-go/releases/tag/v1.20.0 for backward compat.