Skip to content

github.com/golang/protobuf version for generated files #3187

New issue
New issue
Closed
#3236
Closed
github.com/golang/protobuf version for generated files#3187
#3236
Labels
area/project
@crazy-max

Description

@crazy-max
crazy-max
opened on Oct 17, 2022

github.com/golang/protobuf used to generate proto (1.3.5) is desynced with one from go.mod (1.5.2):

buildkit/hack/dockerfiles/generated-files.Dockerfile

Lines 23 to 25 in 6bff150

ARG PROTOBUF_VERSION=v1.3.5
RUN --mount=target=/root/.cache,type=cache GO111MODULE=on go install \
github.com/golang/protobuf/protoc-gen-go@${PROTOBUF_VERSION}

buildkit/go.mod

Line 35 in 6bff150

github.com/golang/protobuf v1.5.2

We should fix this and also inferred go install from go.mod using tools build constraint to avoid that in the future.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/project

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions