cache: do not ignore readonly option#2562
Merged
sipsma merged 1 commit intomoby:masterfrom Jan 17, 2022
Merged
Conversation
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
sipsma
approved these changes
Jan 17, 2022
Collaborator
sipsma
left a comment
There was a problem hiding this comment.
LGTM, thanks for finding+fixing
sipsma
added a commit
to sipsma/buildkit
that referenced
this pull request
Jan 18, 2022
This adds test coverage for ensuring the readonly parameter is honored as expected in the ref Mount methods. There was a regression introduced during the moby#2335 that went unnoticed until identified and fixed in moby#2562. This test coverage should help prevent similar regressions in the future. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
sipsma
added a commit
to sipsma/buildkit
that referenced
this pull request
Jan 18, 2022
This adds test coverage for ensuring the readonly parameter is honored as expected in the ref Mount methods. There was a regression introduced during moby#2335 that went unnoticed until identified and fixed in moby#2562. This test coverage should help prevent similar regressions in the future. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Member
Collaborator
Author
|
@tonistiigi No, this patch doesn't fully fix #2334. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2491 (comment)
Currently, read-only option for a mount is sometimes ignored and this seems to lead to conflicts between (unexpectedly-)writable overlay mounts (related: #2334).
cc @tonistiigi @crazy-max