new implementation for limiting tcp connections #2259
Merged
tonistiigi merged 4 commits intomoby:masterfrom Jul 16, 2021
Merged
new implementation for limiting tcp connections #2259tonistiigi merged 4 commits intomoby:masterfrom
tonistiigi merged 4 commits intomoby:masterfrom
Conversation
The previous implementation had many issues. Eg. on fetch, even if the data already existed and no remote connections were needed the request would still be waiting in the queue. Or if two fetches of same blob happened together they would take up two places in queue although there was only one remote request. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
aaronlehmann
approved these changes
Jul 15, 2021
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
sipsma
approved these changes
Jul 15, 2021
Collaborator
sipsma
left a comment
There was a problem hiding this comment.
LGTM, it would be good to have a test for resuming incomplete downloads so it can't be silently broken again, but understand it's higher priority to just get this out for the release for now.
Member
Author
Yeah, it is a bit tricky. To be clear it was not that the resuming was broken. It still worked but it was inefficient because on the background it still pulled the parts that it already had on disk just to discard it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2257
The previous implementation #2247 had many issues. Eg. on fetch, even if
the data already existed and no remote connections were needed
the request would still be waiting in the queue. Or if two fetches
of the same blob happened together they would take up two places in the queue
although there was only one remote request.
The second commit adds one extra connection to high-priority requests as described in #2257 .
Third commit fixes resuming incomplete downloads if there is previous data. Looks
like this broke with lazy pulling support and data was always repulled. This also looked
weird in the progress output because progress saw previous data but numbers were not
moving as builder was repelling that data again.
@sipsma @aaronlehmann @AkihiroSuda