add per domain semaphore to limit concurrent connections#2247
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Jul 14, 2021
Merged
add per domain semaphore to limit concurrent connections#2247AkihiroSuda merged 1 commit intomoby:masterfrom
AkihiroSuda merged 1 commit intomoby:masterfrom
Conversation
sipsma
reviewed
Jul 13, 2021
This is a safer alternative until we figure out why http.Transport based limiting fails. Some connections like cache export/import do not have a domain key atm and these connections use global pool. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2a8f414 to
a558ac4
Compare
Member
Author
|
@AkihiroSuda lgty? |
AkihiroSuda
approved these changes
Jul 14, 2021
This was referenced Jul 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a safer alternative until we figure out why
http.Transportbased limiting fails.Some connections like cache export/import do not have a
domain key atm and these connections use a global pool.
Previous attempt #1986
@robtaylor @michaelhelmick
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com