fix: cache preflight cors check for a day #114
Conversation
WalkthroughAdded the HTTP CORS header Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
server/server.go (1)
82-82: LGTM! Preflight caching correctly implemented.The
Access-Control-Max-Ageheader with a 24-hour cache duration will reduce preflight OPTIONS requests from browsers, improving performance. The value and placement are appropriate.Optional: Extract as a constant for maintainability.
If you anticipate needing to adjust this value or reference it elsewhere, consider extracting it as a constant:
const ( // Server timeouts ReadTimeout = 10 * time.Second WriteTimeout = 10 * time.Second IdleTimeout = 120 * time.Second // CORS preflight cache duration (24 hours) CORSMaxAge = 86400 )Then reference it in the middleware:
- w.Header().Set("Access-Control-Max-Age", "86400") + w.Header().Set("Access-Control-Max-Age", strconv.Itoa(CORSMaxAge))
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
server/server.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: lint
- GitHub Check: Analyze (go)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.