fix plot_compare_evokeds topo legend axes placement#9927
Merged
drammock merged 2 commits intomne-tools:mainfrom Dec 3, 2021
Merged
fix plot_compare_evokeds topo legend axes placement#9927drammock merged 2 commits intomne-tools:mainfrom
drammock merged 2 commits intomne-tools:mainfrom
Conversation
agramfort
approved these changes
Oct 30, 2021
Member
Author
|
CI failure should be fixed by #9930 |
Member
Author
|
it looks like I inadvertently deleted this branch from the command line (oops). Reopening |
Member
|
@drammock What's the status of this? My impression was that it had been ~ready to merge a while back, is that still the case? Shall we rebase on |
3cb4fed to
a7c622e
Compare
Member
Author
OK, rebased and force-pushed. AFAIK this should still be ready to go... CI failures were unrelated last time they ran. |
larsoner
added a commit
to GuillaumeFavelier/mne-python
that referenced
this pull request
Dec 6, 2021
* upstream/main: Use fixes._compare_version for version checks everywhere (mne-tools#10091) Fast annotation from mask (mne-tools#10089) fix trace offsets in butterfly mode (mne-tools#10087) fix plot_compare_evokeds topo legend axes placement (mne-tools#9927) doc: clarify ica.apply include and exclude params (mne-tools#10086) MRG: Make y a required parameter in CSP.fit_transform() (mne-tools#10084) Add scrollbar to report tag dropdown menu (mne-tools#10082)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9923
Here are some figures to show how this changes behavior. I've made the figure facecolor gray to more clearly show its edges (for those of you who don't use GitHub dark mode 😎):
EEG
main:
this PR:
MAG
main:
this PR:
GRAD
main:
this PR:
JUST A FEW PICKS (this is what originally revealed the bug)
main:
this PR:
