MRG: Method get_montage() should return good and bad channels.#9920
Merged
agramfort merged 6 commits intomne-tools:mainfrom Oct 29, 2021
mscheltienne:get_montage_should_return_bads
Merged
MRG: Method get_montage() should return good and bad channels.#9920agramfort merged 6 commits intomne-tools:mainfrom mscheltienne:get_montage_should_return_bads
agramfort merged 6 commits intomne-tools:mainfrom
mscheltienne:get_montage_should_return_bads
Conversation
larsoner
reviewed
Oct 28, 2021
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Oct 29, 2021
* upstream/main: API: Deprecate mayavi (mne-tools#9904) MRG: Method get_montage() should return good and bad channels. (mne-tools#9920) Use locking/unlocking for Info.update() (mne-tools#9914)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix .get_montage() returning only good channels.
Spotted in #9914.