Merged
Conversation
Member
Author
|
note: I'm expecting the CIs to be green here (we should wait and see), but the real test will be in the deploy step after this is merged. |
Member
Author
|
rendered doc looks okay:
(look at the first paragraph of each page, it says correctly "Python 3.7"; the 3.7 part is rendered from a variable) |
drammock
added a commit
that referenced
this pull request
Aug 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9634 broke documentation builds because it tried to parse
setup.pyto get the required python version (setup.py is not distributed with the package, so it can only be used that way in git-clone-based installations).This uses either
importlib(py 3.8+) orpkg_resources(py3.7) instead.