MRG, BUG: Fix behavior with constrained_layout=True#9561
Merged
drammock merged 1 commit intomne-tools:mainfrom Jul 12, 2021
Merged
MRG, BUG: Fix behavior with constrained_layout=True#9561drammock merged 1 commit intomne-tools:mainfrom
drammock merged 1 commit intomne-tools:mainfrom
Conversation
larsoner
commented
Jul 12, 2021
| def connect(self): | ||
| """Connect to all the events we need.""" | ||
| self.cidpress = self.cbar.patch.figure.canvas.mpl_connect( | ||
| self.cidpress = self.cbar.ax.figure.canvas.mpl_connect( |
Member
Author
There was a problem hiding this comment.
This is just because cbar.patch is deprecated now, and all we need is the figure so we might as well go through ax instead
drammock
approved these changes
Jul 12, 2021
Member
drammock
left a comment
There was a problem hiding this comment.
so the problem is with calling subplots_adjust? seems like we might need similar changes elsewhere?
agramfort
approved these changes
Jul 12, 2021
Member
Author
Yes and yes. I'm fine with doing the updates piecemeal as we encounter them. This at least takes care of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes evoked.plot_topomap when passing axes from a fig created with
constrained_layout=True