MRG, MAINT: Updates for mpl deprecations#9550
Merged
agramfort merged 1 commit intomne-tools:mainfrom Jul 10, 2021
Merged
Conversation
drammock
approved these changes
Jul 9, 2021
Member
drammock
left a comment
There was a problem hiding this comment.
changes look reasonable, just one tiny request. I'd vote for merging this sooner, rather than waiting for matplotlib/matplotlib#20618 to get fixed.
| color = tp.get_color() | ||
| try: | ||
| color = tp.get_edgecolors() | ||
| except AttributeError: # old MPL |
Member
There was a problem hiding this comment.
can we mention in the comment which version is the critical one? will make it easier to remove the try/except later as our min version changes.
agramfort
approved these changes
Jul 10, 2021
Member
|
thx @larsoner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the latest version of matplotlib I hit some errors in local testing. This fixes them.