MRG, MAINT: Bump requirements, remove cruft#9358
Merged
larsoner merged 1 commit intomne-tools:mainfrom Apr 28, 2021
Merged
Conversation
drammock
reviewed
Apr 28, 2021
| sphinx | ||
| https://github.com/numpy/numpydoc/archive/main.zip | ||
| pydata-sphinx-theme==0.6.1 | ||
| pydata-sphinx-theme>=0.6.3 |
Member
There was a problem hiding this comment.
I would keep this pinned. The theme is still under pretty active development, and its test suite is still being refined.
Suggested change
| pydata-sphinx-theme>=0.6.3 | |
| pydata-sphinx-theme==0.6.3 |
Member
Author
There was a problem hiding this comment.
I assumed that was the original rationale, but I'm hoping that by doing this we can catch their bugs earlier, similar to how we build CircleCI with sphinx-gallery:master. I figure if it starts breaking things in a way we can't easily fix then we can easily add a fixed pin later
Member
There was a problem hiding this comment.
fair enough. I guess staying on latest point release is not as dangerous as being on their latest main, anyway.
drammock
approved these changes
Apr 28, 2021
5 tasks
larsoner
added a commit
to agramfort/mne-python
that referenced
this pull request
May 10, 2021
* upstream/main: FIX: make epoch cropping idempotent (mne-tools#9378) MRG, ENH: Add NIRSport support (mne-tools#9348) MRG, ENH: Make _get_hpi_info public (mne-tools#9369) ENH: Add a playback button to the notebook 3d backend (mne-tools#8741) better docs for permutation_cluster_test (mne-tools#9365) MRG: Add fNIRS to html output (mne-tools#9367) When plotting GFP comparison in Report, don't show sensor layout by default (mne-tools#9366) DOC: Update Mayavi troubleshooting section (mne-tools#9362) more tutorial tweaks (mne-tools#9359) MRG, MAINT: Use native GitHub Actions skip (mne-tools#9361) MAINT: Clean up crufty code [circle front] (mne-tools#9358) API: Complete deprecations (mne-tools#9356) Add qdarkstyle, darkdetect to environment.yml [circle full] (mne-tools#9357) FIX: Fix FIX: Add
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes.pythat required old versions (np.einsum, np.take_along_axis, etc.)oldCI runviz/utils.pythat really belongs infixes.py, which is meant to keep version-specific backward compat shimsXXXandTODOin our codebase and took care of some of them, including:run_tests_as_main_TempDirin tests in most placesmorph_mapscode to their own file rather than living insurface.pyDigMontage.dev_head_tas it's never used or set, and probably was never meant to be there (we have a warning that this class should not be instantiated by users anyway)I'm going to update the "make a release" instructions with steps 1-3 since I think it should come right after the deprecations PR (as it is here).
@drammock I left a fun one behind that you can tackle in a follow-up PR in
mne/viz/_figure.py: