FIX: Prepare for PyVista 0.30.0#9274
Merged
larsoner merged 3 commits intomne-tools:mainfrom Apr 12, 2021
Merged
Conversation
This was referenced Apr 9, 2021
Contributor
Author
larsoner
reviewed
Apr 12, 2021
| python -m pip install --progress-bar off --upgrade --pre --only-binary ":all:" numba llvmlite | ||
| wget -q https://osf.io/kej3v/download -O vtk-9.0.20201117-cp39-cp39-linux_x86_64.whl | ||
| python -m pip install --progress-bar off vtk-9.0.20201117-cp39-cp39-linux_x86_64.whl | ||
| python -m pip install --progress-bar off https://github.com/pyvista/pyvista/zipball/master |
Member
There was a problem hiding this comment.
I went with a solution that should be slightly easier to eventually revert in https://github.com/mne-tools/mne-python/pull/9284/files#diff-838a9c60bcbbc8d01b84e4169048fe3fc03667b383b463c501857b168e54d082R13
Contributor
Author
There was a problem hiding this comment.
Okay sure, I'll use that then
Contributor
Author
|
What do you think @larsoner ? |
Member
|
Thanks @GuillaumeFavelier ! |
larsoner
added a commit
to agramfort/mne-python
that referenced
this pull request
Apr 12, 2021
* upstream/main: MRG: Return empty list of SSP projectors if no ECG, EOG events were found (mne-tools#9277) Better warning message for EDF files with annotations only (mne-tools#9283) FIX: Link [ci skip] FIX: Prepare for PyVista 0.30.0 (mne-tools#9274) Use info for checking more NIRS metadata, not raw (mne-tools#9282) MRG: Use info for checking NIRS metadata, not raw (mne-tools#9280) Fix issue where set ylim parameter gets swapped across channel types in plot_evoked_topo (mne-tools#9207)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the latest version, the API for
_add_observer()anduse_ipyvtkhave been modified. This PR tries to catch up to those changes. Changes are also necessary in PyVistaQt.Follows #9010 (comment)