Fix indexing dipoles read from a bdip file#8963
Merged
hoechenberger merged 4 commits intomne-tools:mainfrom Feb 28, 2021
Merged
Fix indexing dipoles read from a bdip file#8963hoechenberger merged 4 commits intomne-tools:mainfrom
hoechenberger merged 4 commits intomne-tools:mainfrom
Conversation
agramfort
approved these changes
Feb 27, 2021
Member
|
Thanks, @wmvanvliet! |
larsoner
added a commit
to marsipu/mne-python
that referenced
this pull request
Mar 1, 2021
* upstream/main: MAINT: Skip matplotlib pre for now (mne-tools#8973) FIX: Brain lights (mne-tools#8972) MNT: Migrate VTK Widgets (mne-tools#8862) Fix (mne-tools#8971) Fix indexing dipoles read from a bdip file (mne-tools#8963)
larsoner
added a commit
to bloyl/mne-python
that referenced
this pull request
Mar 1, 2021
* upstream/main: MAINT: Skip matplotlib pre for now (mne-tools#8973) FIX: Brain lights (mne-tools#8972) MNT: Migrate VTK Widgets (mne-tools#8862) Fix (mne-tools#8971) Fix indexing dipoles read from a bdip file (mne-tools#8963)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading dipoles from a
*.bdipfile, not all attributes of theDipoleobject were proper numpy arrays. This only becomes apparent when you try to index theDipoleand get indexing errors. A quick PR that adds a unit test and fix for this.