Skip to content

MAINT: Actually use all caches#8702

Merged
larsoner merged 7 commits intomne-tools:masterfrom
larsoner:circle2
Jan 6, 2021
Merged

MAINT: Actually use all caches#8702
larsoner merged 7 commits intomne-tools:masterfrom
larsoner:circle2

Conversation

@larsoner
Copy link
Copy Markdown
Member

@larsoner larsoner commented Jan 6, 2021 •
edited
Loading

According to the CircleCI docs it looks like the cache restore uses whichever key it finds first, treating all subsequent ones as fallbacks. So really we should restore each individually. In theory this should make our CircleCI full build faster and more reliable as it can just use the cached version rather than redownloading every time.

@larsoner
Copy link
Copy Markdown
Member Author

larsoner commented Jan 6, 2021

... also the pip step is now much faster because the cached dependencies can actually be used.

@larsoner
Copy link
Copy Markdown
Member Author

larsoner commented Jan 6, 2021

I noticed that the restoring step only really restored two of our 8 keys, I think this is because the other ones likely exceeded some implicit allowed cache size -- I don't see a limit documented anywhere but I suspect this is what's happening. In any case it shouldn't hurt to split them, and I've documented their decompressed size on disk.

I'll go ahead and merge this once CircleCI is happy, we're going to need to have it build on master to save the new caches, then once a (rebased) PR pushes a commit we should be able to see if it's at least restoring the caches. From earlier iterations it seems like it was doing so for sample but not somato even though they were supposed to be in the same cache, maybe splitting them will help with that.

@larsoner larsoner force-pushed the circle2 branch 2 times, most recently from df38cce to 11f5651 Compare January 6, 2021 17:08
@larsoner larsoner force-pushed the circle2 branch 4 times, most recently from 2bb30a6 to b402bf0 Compare January 6, 2021 17:37
@larsoner larsoner merged commit 68e02f5 into mne-tools:master Jan 6, 2021
@larsoner larsoner deleted the circle2 branch January 6, 2021 18:28
larsoner added a commit to larsoner/mne-python that referenced this pull request Jan 7, 2021
@larsoner
Merge remote-tracking branch 'upstream/master' into tf
3e36b0f 
* upstream/master:
  MAINT: Actually use all caches (mne-tools#8702)
  MRG: Prototype of notebook viz (ipyvtk) (mne-tools#8503)
  MRG: Use caching in Github Actions and Azure Pipelines (mne-tools#8695)
cbrnr pushed a commit to cbrnr/mne-python that referenced this pull request Jan 15, 2021
@larsoner @cbrnr
MAINT: Actually use all caches (mne-tools#8702)
135964c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agramfort agramfort agramfort approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@larsoner @agramfort