FIX: Expose _set_3d_view and _set_3d_title#8392
Merged
larsoner merged 6 commits intomne-tools:masterfrom Oct 20, 2020
Merged
Conversation
Contributor
Author
|
Let me know if this solves your issue @timonmerk |
Contributor
Author
|
This is ready for reviews @agramfort, @larsoner |
Member
|
Can you modify the |
agramfort
approved these changes
Oct 20, 2020
Member
|
@GuillaumeFavelier do we need to backport this? |
larsoner
pushed a commit
that referenced
this pull request
Oct 20, 2020
* Expose _set_3d_view and _set_3d_title * Fix style * Improve coverage * Improve coverage * Improve coverage * Improve coverage
Member
|
... it seemed to work without issue so I backported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the functions
_set_3d_view()and_set_3d_title()to thenotebook3d backend.Related to #8388