WIP : rank was not passed to compute_depth_prior#8368
Merged
larsoner merged 2 commits intomne-tools:masterfrom Oct 15, 2020
Merged
WIP : rank was not passed to compute_depth_prior#8368larsoner merged 2 commits intomne-tools:masterfrom
larsoner merged 2 commits intomne-tools:masterfrom
Conversation
larsoner
approved these changes
Oct 14, 2020
Member
larsoner
left a comment
There was a problem hiding this comment.
Yes this looks like a bug. Should only affect sparse solvers (or very advanced users), though, since the defaults are different for MNE and beamformers.
larsoner
pushed a commit
that referenced
this pull request
Oct 15, 2020
* rank was not passed to compute_depth_prior * update what's new
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hichamjanati can you see if it fixes your problem with MxNE?
@larsoner do you confirm it's a bug?