WIP: Merge time viewer code into Brain#8352
Merged
GuillaumeFavelier merged 4 commits intomne-tools:masterfrom Oct 8, 2020
Merged
WIP: Merge time viewer code into Brain#8352GuillaumeFavelier merged 4 commits intomne-tools:masterfrom
GuillaumeFavelier merged 4 commits intomne-tools:masterfrom
Conversation
Contributor
Author
|
What do you think @agramfort, @larsoner ? |
Member
|
number of red lines matches green lines and if you did not break anything it's ok for me. @larsoner may have a more expert opinion |
larsoner
approved these changes
Oct 8, 2020
Member
larsoner
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge if you're happy @GuillaumeFavelier
13 tasks
marsipu
pushed a commit
to marsipu/mne-python
that referenced
this pull request
Oct 14, 2020
* Move time viewer code into Brain * Fix docstring * Fix docstring * Fix docstring
86 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the code of _TimeViewer into the now public Brain to make the integration of new features easier (c.f. #8335)
This is still a work in progress, some occurences of time_viewer in the code still need to be changed.