MRG, BUG: Fix line color in ICA.plot_overlay#8341
Merged
larsoner merged 1 commit intomne-tools:masterfrom Oct 5, 2020
Merged
Conversation
`ICA.plot_overlay()` didn't seem to work on my system with latest Matplotlib anymore (macOS, both the default and Qt5Agg backends). I would only see black traces. Debugging showed that changig the colors of lines in a figure that has been `show()`n was somehow part of the problem. Now we only `show()` once all plotting operations are done, and this now works with the default macOS and the Qt5Agg backends for me.
Member
Author
|
This should probably also be backported. |
larsoner
pushed a commit
that referenced
this pull request
Oct 5, 2020
`ICA.plot_overlay()` didn't seem to work on my system with latest Matplotlib anymore (macOS, both the default and Qt5Agg backends). I would only see black traces. Debugging showed that changig the colors of lines in a figure that has been `show()`n was somehow part of the problem. Now we only `show()` once all plotting operations are done, and this now works with the default macOS and the Qt5Agg backends for me.
marsipu
pushed a commit
to marsipu/mne-python
that referenced
this pull request
Oct 14, 2020
`ICA.plot_overlay()` didn't seem to work on my system with latest Matplotlib anymore (macOS, both the default and Qt5Agg backends). I would only see black traces. Debugging showed that changig the colors of lines in a figure that has been `show()`n was somehow part of the problem. Now we only `show()` once all plotting operations are done, and this now works with the default macOS and the Qt5Agg backends for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICA.plot_overlay()didn't seem to work on my system with latest Matplotlib anymore (macOS, both the default and Qt5Agg backends). I would only see black traces, instead of red and black. Debugging showed that changig the colors of lines in a figure (in this case, from black to read) that hasbeen
show()n was somehow part of the problem. Now we onlyshow()once all plotting operations are done (We callplt_show(show)at the end of the plotting function), and this now works with the default macOS and the Qt5Agg backends for me.