Merged
Conversation
larsoner
reviewed
Sep 23, 2020
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Member
|
Any need to iterate further? I guess the JSON is created by PyPi rather than being part of the upload directly. So +1 for merging and backporting this and seeing if eventually 0.21.1 looks better |
Member
|
... or you could upload something to test.pypi.org and look at |
Member
Author
|
OK, just created account I'm assuming you need to grant me access to |
Member
|
I'm not an owner there, so it'll have to be @agramfort |
Member
Author
|
Looks like it worked! the new URLs are in the JSON file and the site populates them into the sidebar:
Merging. |
drammock
added a commit
to drammock/mne-python
that referenced
this pull request
Sep 23, 2020
* bump copyright year * add keywords and URLs to setup * ECog -> ECoG Co-authored-by: Eric Larson <larson.eric.d@gmail.com> Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
drammock
added a commit
that referenced
this pull request
Sep 23, 2020
Member
Author
|
backported |
Member
|
Awesome, thanks @drammock |
marsipu
pushed a commit
to marsipu/mne-python
that referenced
this pull request
Oct 14, 2020
* bump copyright year * add keywords and URLs to setup * ECog -> ECoG Co-authored-by: Eric Larson <larson.eric.d@gmail.com> Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8088