Skip to content

MRG, FIX: Fix single handling#8285

Merged
hoechenberger merged 1 commit intomne-tools:masterfrom
larsoner:single
Sep 22, 2020
Merged

MRG, FIX: Fix single handling#8285
hoechenberger merged 1 commit intomne-tools:masterfrom
larsoner:single

Conversation

@larsoner
Copy link
Copy Markdown
Member

@larsoner larsoner commented Sep 21, 2020

Fixes errors of the form:

mne/viz/_brain/_brain.py:564: in add_data
    self.set_data_smoothing(self._data['smoothing_steps'])
mne/viz/_brain/_brain.py:1270: in set_data_smoothing
    self.set_time_point(self._data['time_idx'])
mne/viz/_brain/_brain.py:1346: in set_time_point
    grid.cell_arrays['values'][vertices] = values
../pyvista/pyvista/core/pyvista_ndarray.py:43: in __setitem__
    super().__setitem__(key, value)
E   ValueError: shape mismatch: value array of shape (150,1) could not be broadcast to indexing result of shape (150,)

@larsoner larsoner added the backport-candidate on-merge: backport to maint/1.12 label Sep 21, 2020
@hoechenberger
Copy link
Copy Markdown
Member

hoechenberger commented Sep 22, 2020

All tests passed, Travis died / was terminated after successful pytest runs. Merging.

@hoechenberger hoechenberger merged commit f81fbe4 into mne-tools:master Sep 22, 2020
@hoechenberger
Copy link
Copy Markdown
Member

hoechenberger commented Sep 22, 2020

Thanks, @larsoner

@agramfort
Copy link
Copy Markdown
Member

agramfort commented Sep 22, 2020

@hoechenberger can you take care of the backport to 0.21?

@hoechenberger
Copy link
Copy Markdown
Member

hoechenberger commented Sep 22, 2020

@agramfort Will do!

hoechenberger pushed a commit to hoechenberger/mne-python that referenced this pull request Sep 22, 2020
@larsoner @hoechenberger
FIX: Fix single handling (mne-tools#8285)
4fe59bf
@hoechenberger hoechenberger mentioned this pull request Sep 22, 2020
Merged
agramfort pushed a commit that referenced this pull request Sep 22, 2020
@larsoner @agramfort
FIX: Fix single handling (#8285)
a95ecdc
@larsoner larsoner deleted the single branch September 22, 2020 13:11
@larsoner larsoner added backported and removed backport-candidate on-merge: backport to maint/1.12 labels Sep 22, 2020
@larsoner
Copy link
Copy Markdown
Member Author

larsoner commented Sep 22, 2020

FYI @hoechenberger don't forget to switch the label to backported once you're done backporting

@larsoner
Copy link
Copy Markdown
Member Author

larsoner commented Sep 22, 2020

Actually I guess that's on @agramfort since he merged the backport PR but didn't change the label here

@hoechenberger
Copy link
Copy Markdown
Member

hoechenberger commented Sep 22, 2020

@larsoner Thanks, I wasn't aware of this. Thought once it's closed, that's all good. But I understand that sometimes one might close an issue / PR without actually finalizing the backport, so adding a different label is less ambiguous.

marsipu pushed a commit to marsipu/mne-python that referenced this pull request Oct 14, 2020
@larsoner @marsipu
FIX: Fix single handling (mne-tools#8285)
7394374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agramfort agramfort agramfort approved these changes

Assignees

No one assigned

Labels

backported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@larsoner @hoechenberger @agramfort