Gracefully handle invalid EDF dates#8283
Conversation
|
we just need to pick one. No preference.
… |
|
Is this some known issue (two jobs fail)? |
Fixed in |
|
Azure jobs fail because they can't create the temp file. Is there a recommended mechanism that works? |
|
@cbrnr try using our _TempDir() function? |
|
Thanks, this should fix the problem. FWIW, the problem with |
Sure. Have we already converged on a new format? I think we agreed to include the GitHub PR number, so my entry would look like this: If you agree I could change the only other entry by @larsoner accordingly. |
|
remember we use rst and not md. I am fine adding url to the PR
… |
Right, so this would be: Or leaving the contributor outside parens like before: |
|
LGTM !
… |
There was a problem hiding this comment.
And if we really want the # in front, you or I could update the substitution code easily to use that instead of the gh- lead-in. gh- was chosen as the lead-in to match SciPy's documentation of github links, but we could change it, especially since github-changelog-generator uses the # terminology (and so do we typically).
I think this would be a good idea. Where do I change this? |
|
Found it, let's see if this works. |
Can we have "GH-XXXX"? Seems more generic and, should we ever move to another platform, will help us distinguish |
|
I'd prefer #XXX because it looks more familiar and other platforms (e.g. GitLab) also use this notation. Actually, the platform is not relevant for users, so showing GH-XXX might raise questions why GH is important, and should we switch to GitLab using GL-XXX would be similar. Instead, if we use #XXX we don't include the specific platform at all. |
|
@larsoner could it be that the current substitution mechanism only works for issues? |
|
See comment a few lines down: and try it (have to use code-mode so that GitHub doesn't substitute; copy-paste enter and it should redirect here):
|
|
Sorry I don't get it. I'd like to link to a PR, how could the substitution distinguish between issues and PRs if both use identical (but separate) ranges starting from 1? We already have some issue links in our roadmap, so we can't just change everything to point to PRs. |
They are not separate really. They don't overlap. Try this link and see where it goes:
|
|
Or directly try the output links https://22434-1301584-gh.circle-artifacts.com/0/dev/whats_new.html |
🤯 TIL! |
|
All green 🚀 ! |
IMO |
|
Thanks @cbrnr |
|
@hoechenberger I'll backport this at the same time as #8287 |
* Use 1900-01-01 00:00:00 for invalid EDF dates * Set invalid date to None * Add test * Use _TempDir * Add changes/latest.inc entry * Include GH PR numbers * Forgot angle brackets * Use :gh: Co-authored-by: Eric Larson <larson.eric.d@gmail.com> * More :gh: Co-authored-by: Eric Larson <larson.eric.d@gmail.com> * Change gh- to # Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
* Use 1900-01-01 00:00:00 for invalid EDF dates * Set invalid date to None * Add test * Use _TempDir * Add changes/latest.inc entry * Include GH PR numbers * Forgot angle brackets * Use :gh: Co-authored-by: Eric Larson <larson.eric.d@gmail.com> * More :gh: Co-authored-by: Eric Larson <larson.eric.d@gmail.com> * Change gh- to # Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Fixes #8281.