MRG, MAINT: Reduce memory usage of examples#8254
Merged
larsoner merged 3 commits intomne-tools:masterfrom Sep 14, 2020
Merged
Conversation
Member
Author
|
These are hopefully pretty straightforward memory reduction methods, let's see if things work in |
marsipu
pushed a commit
to marsipu/mne-python
that referenced
this pull request
Oct 14, 2020
* MAINT: Reduce memory usage of examples * STY: Fix [ci skip] * FIX: verbose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8241
The goal is to reduce memory usage -- we'll see what CircleCI reports here vs on
master. But some relevant test timings locally on master:This PR:
So it looks like removing the
preload=Truefrom theread_source_spacecode (which was causing memory usage jumps in the hundreds of MB range) seems to be okay