MRG, BUG: Fix errors in IO/loading/projectors#8210
Merged
larsoner merged 7 commits intomne-tools:masterfrom Sep 6, 2020
Merged
MRG, BUG: Fix errors in IO/loading/projectors#8210larsoner merged 7 commits intomne-tools:masterfrom
larsoner merged 7 commits intomne-tools:masterfrom
Conversation
Member
Author
|
Okay, should be all good now @agramfort |
agramfort
reviewed
Sep 4, 2020
Member
agramfort
left a comment
There was a problem hiding this comment.
shall we merge this one and try to fix the other readers in other PRs?
| _test_raw_reader(read_raw_gdf, input_fname=gdf2_path + '.gdf', | ||
| eog=None, misc=None) | ||
| eog=None, misc=None, | ||
| test_scaling=False, # XXX this should be True |
Member
There was a problem hiding this comment.
you mean it's not working yet on gdf data?
Member
Author
There was a problem hiding this comment.
The values seem too large. Each of these requires some investigation. I think it should be done in another PR. It's possible nothing is broken but it would be good to understand why the EEG values are around 0.01 even after removing the mean or applying an average reference (for example)
| with pytest.warns(RuntimeWarning, match='Acquisition skips detected'): | ||
| raw = _test_raw_reader(read_raw_egi, input_fname=fname) | ||
| raw = _test_raw_reader(read_raw_egi, input_fname=fname, | ||
| test_scaling=False, # XXX probably some bug |
larsoner
added a commit
to libertyh/mne-python
that referenced
this pull request
Sep 9, 2020
* upstream/master: (489 commits) MRG, DOC: Fix ICA docstring, add whitening (mne-tools#8227) MRG: Extract measurement date and age for NIRX files (mne-tools#7891) Nihon Kohden EEG file reader WIP (mne-tools#6017) BUG: Fix scaling for src_mri_t in coreg (mne-tools#8223) MRG: Set pyvista as default 3d backend (mne-tools#8220) MRG: Recreate our helmet graphic (mne-tools#8116) [MRG] Adding get_montage for montage to BaseRaw objects (mne-tools#7667) ENH: Allow setting tqdm backend (mne-tools#8177) [MRG, IO] Persyst reader into Raw object (mne-tools#8176) MRG, BUG: Fix errors in IO/loading/projectors (mne-tools#8210) MAINT: vectorize _read_annotations_edf (mne-tools#8214) FIX : events_from_annotation when annotations.orig_time is None and f… (mne-tools#8209) FIX: do not project to sphere; DOC - explain how to get EEGLAB-like topoplots (mne-tools#7455) [MRG, DOC] Added linear algebra of transform to doc (mne-tools#7087) FIX: Travis failure on python3.8.1 (mne-tools#8207) BF: String formatting in exception message (mne-tools#8206) BUG: Fix STC limit bug (mne-tools#8202) MRG, DOC: fix ica tutorial (mne-tools#8175) CSP component order selection (mne-tools#8151) MRG, ENH: Add on_missing to plot_events (mne-tools#8198) ...
marsipu
pushed a commit
to marsipu/mne-python
that referenced
this pull request
Oct 14, 2020
* WIP: Expose errors * WIP * WIP * FIX: Almost * FIX: Better test * FIX: Fix bugs * FIX: More lenient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to add a tiny test to #8176 to ensure
_mult_cal_oneis used properly, but I found out it's not used properly in a number of existing readers. Basically it means (I think) that for all readers for a non-preloadedraw:raw.apply_proj().load_data().get_data()was broken (fix WIP)raw.apply_proj().pick(...)was broken (now disallowed; we didn't allow this until this release cycle so not so bad)_mult_cal_onewas not used properly, so projectors were not applied when data were not preloadedThis sounds bad, but
(1)hopefully isn't too common a practice, (2) is within-release and probably rare, and (3) affects formats where using projections are less common (and using a patterns involving not preloading that are hopefully uncommon).