Skip to content

MRG: Improve lighting in 3D viz#8182

Merged
larsoner merged 3 commits intomne-tools:masterfrom
GuillaumeFavelier:lighting
Sep 2, 2020
Merged

MRG: Improve lighting in 3D viz#8182
larsoner merged 3 commits intomne-tools:masterfrom
GuillaumeFavelier:lighting

Conversation

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Sep 1, 2020

This PR reworks lighting in 3d viz scenes:

master PR
image image
image image
image image
image image
image image

Related to #6731 (comment)

@GuillaumeFavelier GuillaumeFavelier self-assigned this Sep 1, 2020
@GuillaumeFavelier GuillaumeFavelier changed the title Improve lighting in 3D viz WIP: Improve lighting in 3D viz Sep 1, 2020
@agramfort
Copy link
Copy Markdown
Member

agramfort commented Sep 1, 2020 via email

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

GuillaumeFavelier commented Sep 1, 2020

The goal is to reproduce the lighting method used by Mayavi. Should I maybe update the table to integrate it?

@larsoner
Copy link
Copy Markdown
Member

larsoner commented Sep 1, 2020

Yes I have noticed that they are different. The right still doesn't quite look like Mayavi, though -- the contrast is too large. Maybe the ambient light level is higher in Mayavi?

@larsoner larsoner added this to the 0.21 milestone Sep 1, 2020
@agramfort
Copy link
Copy Markdown
Member

agramfort commented Sep 1, 2020 via email

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

GuillaumeFavelier commented Sep 1, 2020

Hm... I checked the ambient and diffuse values and they are the same (mayavi against pyvista) 🤔

I'll keep looking

@larsoner
Copy link
Copy Markdown
Member

larsoner commented Sep 1, 2020

Difference in light follows camera vs not? Default light locations?

@larsoner
Copy link
Copy Markdown
Member

larsoner commented Sep 1, 2020

Maybe this?

https://github.com/nipy/PySurfer/blob/master/surfer/viz.py#L3496-L3502

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

GuillaumeFavelier commented Sep 2, 2020

It's trickier than it seems. It's technically 3 lights (of type CameraLight) but the first one (of type HeadLight) is actually disabled.

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

GuillaumeFavelier commented Sep 2, 2020 •
edited
Loading

Updated table after e23c884

PyVista (before) PyVista (now) Mayavi
image image image
image image -
image image -
image image image
image image image

Note: Locally, I had to downgrade my VTK to 8.1.2 to get Mayavi to plot without z-fighting

@agramfort
Copy link
Copy Markdown
Member

agramfort commented Sep 2, 2020 via email

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

GuillaumeFavelier commented Sep 2, 2020

@larsoner I pushed 4df834b to integrate #8182 (comment)

@GuillaumeFavelier GuillaumeFavelier changed the title WIP: Improve lighting in 3D viz MRG: Improve lighting in 3D viz Sep 2, 2020
larsoner
larsoner reviewed Sep 2, 2020
View reviewed changes
larsoner
larsoner reviewed Sep 2, 2020
View reviewed changes
mne/viz/backends/_pyvista.py
x = np.sin(theta) * np.sin(phi)
y = np.cos(phi)
z = np.cos(theta) * np.sin(phi)
return x, y, z
Copy link
Copy Markdown
Member

@larsoner larsoner Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably use mne.transforms.sph_to_cart

@larsoner
Copy link
Copy Markdown
Member

larsoner commented Sep 2, 2020

I'll merge this, let's take care of sph_to_cart deduplication in another PR when someone sees it and remembers to do it

@larsoner larsoner merged commit ff6751d into mne-tools:master Sep 2, 2020
@larsoner
Copy link
Copy Markdown
Member

larsoner commented Sep 2, 2020

Thanks @GuillaumeFavelier !

@GuillaumeFavelier GuillaumeFavelier deleted the lighting branch September 2, 2020 14:39
@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Sep 8, 2020
Merged
marsipu pushed a commit to marsipu/mne-python that referenced this pull request Oct 14, 2020
@GuillaumeFavelier @marsipu
MRG: Improve lighting in 3D viz (mne-tools#8182)
045c818 
* Improve lighting

* Turn off the headlight

* Orient lights
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner left review comments

Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels

VIZ

Projects

None yet

Milestone

0.21

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeFavelier @agramfort @larsoner