VIZ, BUG: fix tickmarks in evoked topomap colorbar#7980
Merged
larsoner merged 2 commits intomne-tools:masterfrom Jul 9, 2020
Merged
VIZ, BUG: fix tickmarks in evoked topomap colorbar#7980larsoner merged 2 commits intomne-tools:masterfrom
larsoner merged 2 commits intomne-tools:masterfrom
Conversation
larsoner
approved these changes
Jul 8, 2020
Member
larsoner
left a comment
There was a problem hiding this comment.
Maybe latest.inc in BUG stating that the colorbar ticks are fixed in topomap plotting?
Member
Author
|
@larsoner any idea why the CircleCI "details" link is going to the wrong job? Has this been noticed before? |
Member
|
Do you have CircleCI enabled on your fork? If so it's probably scientific-python/circleci-artifacts-redirector-action#7 |
Member
|
Actually this is a CircleCI problem, I don't even see the artifacts here |
Member
|
Oh wait that's the wrong job... |
Member
|
So yes it's a CircleCI problem that for some reason the deploy status for |
Member
Author
|
yes, that's what I was just typing :) |
Member
Author
|
I submitted a ticket to CircleCI about this. |
Member
|
Thanks @drammock |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Jul 14, 2020
* upstream/master: (21 commits) MRG: Add SSP projectors to Report (mne-tools#7991) BUG: Fix warning (mne-tools#8006) WIP: TFR Doc/test changes (mne-tools#7998) MAINT: Remove numpydoc test on 3.6 (mne-tools#8005) MAINT: Better error message for mismatch (mne-tools#8007) MRG: Allow removal of active projectors if channels they applied to have meanwhile been dropped (mne-tools#8003) MRG Freesurfer coordinate frame tutorial (mne-tools#7578) FIX: Fix stockwell checks (mne-tools#7996) MRG, ENH: Add array-spacing plugin and reorganize deps (mne-tools#7997) MRG, ENH: Reduce memory usage of Welch PSD (mne-tools#7994) STY: One more [ci skip] STY: Docstyle [ci skip] Report parsing (mne-tools#7990) MRG, ENH: BrainVision impedance parsing (mne-tools#7974) BUG: Fix missing source space points (mne-tools#7988) [MRG] Strip base directory name from Report captions when using parse_folder (mne-tools#7986) DOC: Update estimates [skip travis] (mne-tools#7987) DOC: Try to improve find_bad_channels_maxwell doc (mne-tools#7982) VIZ, BUG: fix tickmarks in evoked topomap colorbar (mne-tools#7980) Add low-pass filter to find_bad_channels_maxwell() (mne-tools#7983) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7956
When the last topomap drawn has low variance and hence no visible contour lines, only one tickmark is drawn on the colorbar, because it uses the plotted contours instead of the precomputed contour levels based on vmin/vmax.
mne-python/mne/viz/topomap.py
Lines 1763 to 1764 in 2965cc3