MRG, VIZ, BUG: handle CSD channel type when topo plotting#7935
Merged
larsoner merged 5 commits intomne-tools:masterfrom Jun 26, 2020
Merged
MRG, VIZ, BUG: handle CSD channel type when topo plotting#7935larsoner merged 5 commits intomne-tools:masterfrom
larsoner merged 5 commits intomne-tools:masterfrom
Conversation
Member
Seems like it's safest just to add another return value |
Member
Author
|
All green; this one's ready for review/merge. |
agramfort
reviewed
Jun 26, 2020
agramfort
approved these changes
Jun 26, 2020
Member
|
Thanks @drammock |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Jul 8, 2020
* upstream/master: (30 commits) MRG: Add remove_labels to _Brain (mne-tools#7964) Add get_picked_points (mne-tools#7963) ENH: Add OpenGL info to mne sys_info (mne-tools#7976) [MRG] Fix reject_tmin and reject_tmax for reject_by_annotation in mne.Epochs (mne-tools#7967) mrg: Add scalar mult and div operators for AverageTFR (mne-tools#7957) MRG, MAINT: Cleaner workaround for Sphinx linking issue (mne-tools#7970) MRG, ENH: Speed up epochs.copy (mne-tools#7968) MRG, BUG: Allow ref mags to have a comp grade (mne-tools#7965) do not forget to pass adjacency (mne-tools#7961) [MRG] fix Issue with stc.project after restricting to a label (mne-tools#7950) Only process nirx event file if present (mne-tools#7951) MRG+1: BUG: info['bads'] order shouldn't matter in write_evokeds() (mne-tools#7954) Fix some small glitches introduced via mne-tools#7845 (mne-tools#7952) Add time player (mne-tools#7940) MAINT: Clean up VTK9 offset array [circle front] (mne-tools#7953) MAINT: Skip a few more on macOS (mne-tools#7948) fix links [skip travis] (mne-tools#7949) MRG, MAINT: Tweak CIs (mne-tools#7943) MRG, BUG: Fix vector scaling (mne-tools#7934) MRG, VIZ, BUG: handle CSD channel type when topo plotting (mne-tools#7935) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7933
The approach in 1b9ff53 works, in that it yields a correct topo layout for the CSD-transformed EEG data. However, it breaks 3 tests in
mne/viz/tests/test_topo.pyso it's probably not an approach worth keeping. Other possible approaches:has_eeg_csd_coils?) tomne.channels.channels._get_ch_inforather than hacking it to returnTrueforhas_eeg_coilswhen only CSD channels are present.mne.channels.layout.make_eeg_layout, use a booleanallow_csdparameter instead of ach_types=['eeg', 'csd']parameter; and makeeeg=Truealways the case in the call topick_typestherein.I'm not very familiar with this part of the codebase, so any suggestions are welcome.