MRG, ENH: Automatically fix magnetometers when maxwell filtering#7929
Merged
larsoner merged 3 commits intomne-tools:masterfrom Jun 25, 2020
Merged
MRG, ENH: Automatically fix magnetometers when maxwell filtering#7929larsoner merged 3 commits intomne-tools:masterfrom
larsoner merged 3 commits intomne-tools:masterfrom
Conversation
larsoner
commented
Jun 25, 2020
Comment on lines
+1404
to
+1415
| # From email exchanges, systems with the larger T2 coil only use the cal | ||
| # value of 2.09e-11. Newer T3 magnetometers use 4.13e-11 or 1.33e-10 | ||
| # (Triux). So we can use a simple check for > 3e-11. | ||
| for ii in picks: | ||
| ch = info['chs'][ii] | ||
| if ch['coil_type'] in (FIFF.FIFFV_COIL_VV_MAG_T1, | ||
| FIFF.FIFFV_COIL_VV_MAG_T2): | ||
| old_mag_inds.append(ii) | ||
| if use_cal: | ||
| if ch['cal'] > 3e-11: | ||
| old_mag_inds.append(ii) | ||
| else: | ||
| old_mag_inds.append(ii) |
Member
There was a problem hiding this comment.
This should do it. I suppose the processed files will inherit the correct mag coil types.
agramfort
approved these changes
Jun 25, 2020
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Jun 25, 2020
* upstream/master: MRG, ENH: Automatically fix magnetometers when maxwell filtering (mne-tools#7929) MRG: Prepare migration to PyVista 0.25 (mne-tools#7791) MAINT: Simpler VTK [circle front] (mne-tools#7931)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by Jukka