Skip to content

fix evoked nave → inverse guidance#7881

Merged
larsoner merged 1 commit intomne-tools:masterfrom
drammock:fix-tutorial-caveat
Jun 8, 2020
Merged

fix evoked nave → inverse guidance#7881
larsoner merged 1 commit intomne-tools:masterfrom
drammock:fix-tutorial-caveat

Conversation

@drammock
Copy link
Copy Markdown
Member

@drammock drammock commented Jun 8, 2020

updates the tutorial guidance regarding combine_evoked and inverse imaging.

Copy link
Copy Markdown
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much clearer now, thank you!

@larsoner larsoner merged commit fdd68c3 into mne-tools:master Jun 8, 2020
@larsoner
Copy link
Copy Markdown
Member

larsoner commented Jun 8, 2020

Thanks @drammock

@drammock drammock deleted the fix-tutorial-caveat branch June 8, 2020 20:41
# not be done** if you intend to perform inverse imaging on the resulting
# Note that the ``nave`` attribute of the resulting `~mne.Evoked` object will
# reflect the *effective* number of averages, and depends on both the ``nave``
# attributes of the contributing `~mne.Evoked` objects and and the weights at
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and and

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in #7882

larsoner added a commit to larsoner/mne-python that referenced this pull request Jun 17, 2020
* upstream/master: (24 commits)
  WIP: Fix Travis (mne-tools#7906)
  WIP: Prototype of notebook viz (screencast) (mne-tools#7758)
  MRG, FIX: Speed up I/O tests, mark some slow (mne-tools#7904)
  Proper attribution for Blender tutorial (mne-tools#7900)
  MAINT: Check usage [ci skip] (mne-tools#7902)
  Allow find_bad_channels_maxwell() to return scores (mne-tools#7845)
  Warn if NIRx directory structure has been modified from original format (mne-tools#7898)
  Pin pvyista to 0.24.3 (mne-tools#7899)
  MRG: Add support for reading and writing sufaces to .obj (mne-tools#7824)
  Fix _auto_topomap_coords docstring. (mne-tools#7895)
  MRG, FIX: Ensure Info H5-writeable (mne-tools#7887)
  Website contents (mne-tools#7889)
  MRG, ENH: Add mri_resolution="sparse" (mne-tools#7888)
  MRG, ENH: Allow disabling FXAA (mne-tools#7877)
  remove "and and" [ci skip] (mne-tools#7882)
  fix evoked nave → inverse guidance (mne-tools#7881)
  ENH: Better error messages (mne-tools#7879)
  FIX : EDF+ Annotation Timestamps missing sub-second accuracy (mne-tools#7875)
  FIX: Fix get_channel_types (mne-tools#7878)
  MRG, BUG: Fix combine evokeds (mne-tools#7869)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants