[MRG] split_naming='bids' changes from _part-%d to _split-%d#7794
[MRG] split_naming='bids' changes from _part-%d to _split-%d#7794agramfort merged 4 commits intomne-tools:masterfrom
Conversation
| modality = deconstructed_base.pop(idx) | ||
| base = '_'.join(deconstructed_base) | ||
| use_fname = '%s_part-%02d_%s%s' % (base, part_idx, modality, ext) | ||
| use_fname = '{}_split-{:02}_{}{}'.format(base, part_idx, modality, ext) |
There was a problem hiding this comment.
We can use f-strings now :) I think it makes this line much easier to read, but I'll leave this up to you – your PR ;)
| use_fname = '{}_split-{:02}_{}{}'.format(base, part_idx, modality, ext) | |
| use_fname = f'{base}_split-{part_idx:02}_{modality}{ext}' |
There was a problem hiding this comment.
Only do this if we don't plan on backporting
There was a problem hiding this comment.
uff, actually backporting would be nice ... damnit. I'll revert the last commit. 😭
There was a problem hiding this comment.
@larsoner to which MNE versions can we backport this? and how much effort is it? ideally we'd backport it to the version that first introduced split_naming='bids' and all following ones 🤔
related: do we have stats (histogram) which MNE versions are mostly used (downloaded)?
There was a problem hiding this comment.
do we have stats (histogram) which MNE versions are mostly used (downloaded)?
No idea...
We have never backported beyond a single previous release AFAIK. I'd say just backport to 0.20 unless you see a real need for it in 0.19.x |
|
thx @sappelhoff |
|
@agramfort @sappelhoff do we need to backport and release another 0.20.x for this? |
|
It'd be "nice to have" but not a crucial thing. So it depends on (1) how much work it is, and (2) how much other stuff needs to be backported. I would backport if it's not a lot of work and it's part of a package of other fixes. Else, it's probably fine to leave it alone. |
|
yes it would be nice but not critical
… |
* _part- -> _split- for split_naming='bids' * add whatsnew * DOC: minor link fix * Update doc/changes/latest.inc Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
* upstream/master: (74 commits) FIX: Correct a bug in find_bads_eog (mne-tools#7797) [MRG] split_naming='bids' changes from _part-%d to _split-%d (mne-tools#7794) MRG, MAINT, DOC: Remove spyder (mne-tools#7796) MAINT: fixes for linkcheck (mne-tools#7762) [WIP] Update ieeg data example for ECoG (mne-tools#7768) fix examples/tutorials [circle full] (mne-tools#7786) MAINT: Clean up VTK and add to pre on Azure (mne-tools#7780) ENH: Add matplotlib animation support [skip travis] (mne-tools#7783) MRG, API: change out_type default in permutation_cluster_(1samp_)test (mne-tools#7781) DOC: docstring fixes (mne-tools#7777) MRG, ENH: Add tol_kind option (mne-tools#7736) MRG, DOC: Notes about info (mne-tools#7772) ENH: Speed up NIRx read without preload (mne-tools#7759) Minor plot_raw aes improvement (mne-tools#7770) MRG, FIX: Fixes for BEM contours (mne-tools#7763) MRG, STY: Fix E741 (mne-tools#7767) MRG, ENH - Plot optodes in plot_alignment for fNIRS channels (mne-tools#7747) FIX: Update NIH support [skip travis] (mne-tools#7766) MAINT: Bump tol for gamma map test (mne-tools#7764) MRG, FIX: Fix MRI orientations (mne-tools#7725) ...
closes #7776