MRG: Set _Brain window title#7396
Merged
agramfort merged 3 commits intomne-tools:masterfrom Mar 6, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7396 +/- ##
==========================================
+ Coverage 90.00% 90.01% +0.01%
==========================================
Files 453 453
Lines 82115 82223 +108
Branches 12999 13011 +12
==========================================
+ Hits 73904 74015 +111
+ Misses 5387 5382 -5
- Partials 2824 2826 +2 |
Contributor
Author
|
I had to move |
Contributor
Author
|
I think this is ready to be merged @agramfort, @larsoner |
Member
This was referenced Mar 6, 2020
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Change window title * Use subject_id as header * Move _set_3d_title
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Change window title * Use subject_id as header * Move _set_3d_title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows #7382 and unifies the behaviour of the
titleparameter of_Brain.It's of course still possible to add a title string label with
set_3d_title().It's an item of #7162