MRG: Add reset_camera() primitive in _Renderer#7390
Merged
agramfort merged 4 commits intomne-tools:masterfrom Mar 5, 2020
Merged
MRG: Add reset_camera() primitive in _Renderer#7390agramfort merged 4 commits intomne-tools:masterfrom
agramfort merged 4 commits intomne-tools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7390 +/- ##
==========================================
+ Coverage 89.99% 90.01% +0.01%
==========================================
Files 453 453
Lines 82098 82111 +13
Branches 12997 12999 +2
==========================================
+ Hits 73887 73911 +24
+ Misses 5385 5378 -7
+ Partials 2826 2822 -4 |
Contributor
Author
|
I think this is ready to be merged @agramfort, @larsoner |
Member
|
thx @GuillaumeFavelier ! |
86 tasks
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Add reset_camera() primitive * Add reset_camera to test_renderer * Add safety check * Improve safety check
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Add reset_camera() primitive * Add reset_camera to test_renderer * Add safety check * Improve safety check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
focalpointissue whenhemi='both'in _TimeViewer. It should be placed between the hemispheres.masterIt's an item of #7162