MRG, MAINT: Use context manager for tests#7280
MRG, MAINT: Use context manager for tests#7280GuillaumeFavelier merged 2 commits intomne-tools:masterfrom
Conversation
I totally agree, I had something similar in mind. It's just that I would like to avoid to manipulate directly |
|
Also, it's an item of #7162 |
|
The tests pass now, which is nice. I wonder if it's random variation, or maybe something actually wasn't getting set properly in I can try turning it into |
Where did it fail? |
|
Ahh I thought |
Codecov Report
@@ Coverage Diff @@
## master #7280 +/- ##
==========================================
- Coverage 89.79% 89.77% -0.03%
==========================================
Files 447 447
Lines 80617 79826 -791
Branches 12882 12878 -4
==========================================
- Hits 72393 71662 -731
+ Misses 5392 5306 -86
- Partials 2832 2858 +26 |
|
@GuillaumeFavelier feel free to merge if you're happy |
|
... and then you could rebase / merge into #7247 |
GuillaumeFavelier
left a comment
There was a problem hiding this comment.
Those changes are simply awesome, thank you @larsoner
* API: Unify * MAINT: Use context manager for tests
* API: Unify * MAINT: Use context manager for tests
@GuillaumeFavelier I think that in theory this should be equivalent to what is in
masterbut cleaner because it uses acontextmanager.