MRG, FIX: Dont require PySurfer for PyVista#7266
Merged
larsoner merged 6 commits intomne-tools:masterfrom Jan 30, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7266 +/- ##
==========================================
- Coverage 89.8% 89.79% -0.01%
==========================================
Files 447 447
Lines 80488 80502 +14
Branches 12866 12875 +9
==========================================
+ Hits 72279 72289 +10
- Misses 5385 5387 +2
- Partials 2824 2826 +2 |
Member
Author
|
Okay I think this should work now, @GuillaumeFavelier feel free to look. In theory it might also help with #7198 |
GuillaumeFavelier
approved these changes
Jan 30, 2020
Contributor
GuillaumeFavelier
left a comment
There was a problem hiding this comment.
LGTM. I tested it too and everything is fine for me.Thanks for refactoring.
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* FIX: Dont require PySurfer for PyVista * FIX: Fix report * FIX: Restore test * ENH: Even cleaner * FIX: Cast * FIX: Fix check
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* FIX: Dont require PySurfer for PyVista * FIX: Fix report * FIX: Restore test * ENH: Even cleaner * FIX: Cast * FIX: Fix check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7239
Closes #7198
@mmagnuski feel free to try it
@GuillaumeFavelier this refactors some of the logic of how the
renderernamespace is populated. This makes it so that we don't need to nest imports in thebackendsubmodules anymore, and I think makes the logic/flow a bit clearer. WIP because I'm not 100% sure it's correct, feel free to look and let me know if it makes sense to you.